Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new floor sprites #5690

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Conversation

thedyze
Copy link
Contributor

@thedyze thedyze commented Nov 9, 2024

Checklist

Required

Optional

  • I have documented the changes in the appropriate location in the doc/ folder.

Purpose of change

To continue improving the BN graphics, specifically floors with this PR.

Describe the solution

This change adds new graphics for some of the more common floor tiles

  • Linoleum white, gray
  • Concrete
  • Waxed floor + yellow variant

This changes concrete from a multi tile sprite in favor of a single tile with a weighted array fg, and a sand bg tile.
The multi tile wasn't really adding much for looks, it was more or less the same tile with some very basic highlights.

floor

floor1

Additional context

Also moved a few lines in the documentation, which were listed under the incorrect file.

@github-actions github-actions bot added docs PRs releated to docs page JSON related to game datas in JSON format. labels Nov 9, 2024
Copy link
Contributor

autofix-ci bot commented Nov 9, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@chaosvolt chaosvolt merged commit 839a095 into cataclysmbnteam:main Nov 9, 2024
9 checks passed
@thedyze thedyze deleted the floorSprites branch November 9, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants